Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent registry-creds configure from failing when a secret does not exist. #6380

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Prevent registry-creds configure from failing when a secret does not exist. #6380

merged 1 commit into from
Jan 30, 2020

Conversation

akshaysu12
Copy link
Contributor

@akshaysu12 akshaysu12 commented Jan 23, 2020 •
edited by medyagh
Loading

…l when a secret does not exist.

closes #5885

@k8s-ci-robot
Copy link
Contributor

Welcome @akshaysu12!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @akshaysu12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akshaysu12
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

tstromberg
tstromberg reviewed Jan 23, 2020
View reviewed changes
pkg/minikube/service/service.go Outdated
if err != nil {
return &retry.RetriableError{Err: err}
}
secret, _ := secrets.Get(name, meta.GetOptions{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum, this should log or display an error rather than hide it entirely. I'm not exactly sure which is appropriate here, but naively glog.Errorf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, logging makes sense. I feel a glog.Infof would be most appropriate as I don't think it should be an error when CreateSecrets is unable to get a secret it is going to create.

@medyagh medyagh changed the title [fixes #5885] Prevent registry-creds configure from failing when a secret does not exist. Prevent registry-creds configure from failing when a secret does not exist. Jan 23, 2020
@RA489
Copy link

RA489 commented Jan 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@akshaysu12 akshaysu12 force-pushed the UpdateRegistryCredsCreateSecret branch from fc3d288 to 2ba3116 Compare January 28, 2020 15:16
@codecov-io
Copy link

Codecov Report

Merging #6380 into master will decrease coverage by 0.83%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6380      +/-   ##
==========================================
- Coverage    38.3%   37.46%   -0.84%     
==========================================
  Files         124      128       +4     
  Lines        8355     8646     +291     
==========================================
+ Hits         3200     3239      +39     
- Misses       4737     4988     +251     
- Partials      418      419       +1
Impacted Files Coverage Δ
pkg/minikube/service/service.go 77.83% <0%> (ø) ⬆️
pkg/minikube/cruntime/cri.go 38.57% <0%> (-20.47%) ⬇️
pkg/minikube/cruntime/docker.go 37.6% <0%> (-6.15%) ⬇️
pkg/minikube/bootstrapper/bsutil/binaries.go 10.52% <0%> (-2.81%) ⬇️
pkg/minikube/config/profile.go 67.32% <0%> (-2.78%) ⬇️
pkg/minikube/bootstrapper/bsutil/kubeadm.go 80.95% <0%> (-2.1%) ⬇️
pkg/minikube/cruntime/crio.go 46.87% <0%> (-2.04%) ⬇️
pkg/minikube/cruntime/containerd.go 45.37% <0%> (-1.75%) ⬇️
pkg/minikube/cluster/cluster.go 38.18% <0%> (-1.66%) ⬇️
pkg/minikube/assets/vm_assets.go 35.96% <0%> (-1.54%) ⬇️
... and 19 more

@medyagh
Copy link
Member

medyagh commented Jan 28, 2020

OK to test

@tstromberg
Copy link
Contributor

/ok-to-test

@tstromberg tstromberg merged commit 50c32d2 into kubernetes:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registry-creds addon: Temporary Error: secrets "registry-creds-ecr" not found
9 participants
@akshaysu12 @k8s-ci-robot @minikube-bot @RA489 @minikube-pr-bot @codecov-io @medyagh @tstromberg @shinespiked